Add secondary requirements to rules #1920
Conversation
WilcoFiers
force-pushed
the
secondary-requirements
branch
from
cf170c0
to
6acae10
Compare
| forConformance: true | ||
| secondary: true |
There was a problem hiding this comment.
This name of "secondary" isn't final yet, and will probably change. This'll be easy to change though so I'm not going to worry about it for now.
WilcoFiers
force-pushed
the
secondary-requirements
branch
from
ab4a34b
to
ce553f9
Compare
| @@ -69,3 +69,6 @@ yarn.lock | |||
|
|
|||
| # Ignore JetBrains IDE file | |||
| .idea | |||
|
|
|||
| # Tmp build directory | |||
| wcag-act-rules-tmp/ | |||
There was a problem hiding this comment.
I accidentally pushed the tmp dir to the repo. Turns out that wasn't in the ignore. It is now.
There was a problem hiding this comment.
That looks good. I have some caveat on the format change that I mentioned there.
Also, we had discussions around, e.g., the 1.3.1/4.1.2 mapping for "role attribute has valid value" (and some other rules whose mappings have change this year). Should we include them here?
It feels like they are more "Satisfy Mapping" in the lingo of https://github.com/w3c/wcag-act/pull/531/files#r954924761 (if the role attribute value exists, things are likely OK ("assuming no other problems") bit if the role is mispelled, we still need further testing to figure out if it does cause a problem).
Not sure if we should handle both kind of secondary mappings in one go or two…
This pull request makes it so that reporting AAA success criteria as failed on rules for AA becomes optional for implementors. I.e. implementors may fail them, but aren't required to.
Anticipating work on w3c/wcag-act#531, this pull request lists a number of success criteria as "secondary". These are criteria that fail when the rule fails, but don't necessarily pass when the rule passed.
This PR is jumping the gun a little on this, but I think this is important to get done because it is causing problems for at least three of the implementors currently. Their implementations are reported as partially consistent for not failing a AAA success criterion, even though the implementor does not support AAA to begin with.
Closes issue(s): w3c/wcag-act-rules#134
Need for Call for Review: 1 week
How to Review And Approve