make visible text content definition objective #1419

WilcoFiers · 2020-08-18T11:26:21Z

Because the definition of Visible text content is used in the applicability, it can not be subjective.
Add a ligature font passed example

Closes #1254, closes #975

Need for Final Call: 1 week

Jym77

Typos.

Jym77 · 2020-08-18T11:36:29Z

pages/glossary/visible-text-content.md

 input_aspects:
  - CSS styling
  - DOM tree
 ---

-Elements that are [visible](#visible), that are of type text, excluding text content in `title` or `alt` attributes, and are not categorized as [non text content](https://www.w3.org/WAI/WCAG21/Understanding/non-text-content).
+The _visible text content_ of an [element][] is a set of all [visible][] [text node][] that are a [descendant][] in the [flat tree][] of the element.


Suggested change

The _visible text content_ of an [element][] is a set of all [visible][] [text node][] that are a [descendant][] in the [flat tree][] of the element.

The _visible text content_ of an [element][] is a set of all [visible][] [text nodes][text node] that are [descendants][descendant] in the [flat tree][] of this element.

Jym77 · 2020-08-18T11:40:07Z

_rules/visible-label-in-accessible-name-2ee8b8.md

-The complete [visible text content][] of the target element either matches or is contained within its [accessible name][].
-
-**Note:** Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.
+All [text nodes][] in the [visible text content][] of each target element matches, or is contained within the [accessible name][] of the target element, except for [text nodes][] contains [non-text content][]. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.


Suggested change

All [text nodes][] in the [visible text content][] of each target element matches, or is contained within the [accessible name][] of the target element, except for [text nodes][] contains [non-text content][]. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.

Each [text node][] in the [visible text content][] of each target element matches, or is contained within, the [accessible name][] of this target element, except for [text nodes][] containing [non-text content][]. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.

Maybe even un-nesting a bit to avoid the "except":

Suggested change

All [text nodes][] in the [visible text content][] of each target element matches, or is contained within the [accessible name][] of the target element, except for [text nodes][] contains [non-text content][]. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.

Each [text node][] that is in the [visible text content][] of each target element and does not contain [non-text content][] matches, or is contained within, the [accessible name][] of the target element. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.

I think it's better to use the word "except" to be clear something is an exception, rather then use "or" to chain two conditions together.

updated

Jym77

👍

Jym77 · 2020-08-18T12:36:50Z

_rules/visible-label-in-accessible-name-2ee8b8.md

-The complete [visible text content][] of the target element either matches or is contained within its [accessible name][].
-
-**Note:** Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.
+All [text nodes][] in the [visible text content][] of each target element matches, or is contained within the [accessible name][] of the target element, except for characters used to express [non-text content][]. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.


Suggested change

All [text nodes][] in the [visible text content][] of each target element matches, or is contained within the [accessible name][] of the target element, except for characters used to express [non-text content][]. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.

Each [text nodes][] in the [visible text content][] of each target element matches, or is contained within the [accessible name][] of this target element, except for characters used to express [non-text content][]. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.

Subtle but (IMO) important distinction here. The expectation applies to each applicable element, but within that element, all text nodes have to meet the condition or follow the exception.

The question is whether we want:

each individual text node matches or is contained.

all text nodes, grouped together in one single thingie, match or are contained.

I am not sure what it means for "all test nodes" to match a string. We need to somehow gather "all text nodes" into a single stuff that can match the string. Is it concatenation in tree order? And then, the trimming of whitespace, does it occur before or after gathering all text nodes into a single thingie?

Maybe we want to call in @EmmaJP 😄

I've tried to adjust the order of the wording. Hope that helps clarify it.

Updated

Jym77

I still find the sentence super weird, would personally use "each" and am not sure whether "all" should be singular or plural in that case.

But I won't block this further if I'm the only one having problem with this.

Jym77 · 2020-08-19T08:30:29Z

Also, why did you put the Final Call label on this PR? Looks like a misclick…
#1419 (comment)

_rules/visible-label-in-accessible-name-2ee8b8.md

Co-authored-by: daniel-montalvo <49305434+daniel-montalvo@users.noreply.github.com>

Huh! I thought I had fixed that.

EmmaJP

These changes look good and seem good solutions for the issues raised.

On a side note, as I haven't come across 'widget' used within rules to date I had to look up precisely what it meant in this context. Perhaps indicating a need to add a glossary definition. It could simply refer to https://www.digitala11y.com/widget-role/ or a similar explanation in the aria docs if there is one.

UPDATE: Just came across [widget role]: https://www.w3.org/TR/wai-aria-1.1/#widget_roles 'WAI-ARIA widget roles' in the autocomplete stuff. Might be helpful to add to this rule where relevant.

WilcoFiers · 2020-09-07T11:33:53Z

@EmmaJP I'm not sure what to do with your comment about widget roles. The term "widget role" is linked in this rule to its definition in WAI-ARIA I think that's what you were asking? In which case that's already done.

make visible text content definition objective

b99cd66

WilcoFiers requested review from Jym77, jeeyyy, ajanec01, carlosapaduarte, daniel-montalvo, EmmaJP and ShadowBB August 18, 2020 11:26

WilcoFiers added the reviewers wanted label Aug 18, 2020

Jym77 previously requested changes Aug 18, 2020

View reviewed changes

WilcoFiers force-pushed the visible-text-subjective branch 2 times, most recently from c4e492f to 5b82c71 Compare August 18, 2020 12:15

address ligature fonts

b25f172

WilcoFiers force-pushed the visible-text-subjective branch from 5b82c71 to b25f172 Compare August 18, 2020 12:15

WilcoFiers requested a review from Jym77 August 18, 2020 12:16

WilcoFiers mentioned this pull request Aug 18, 2020

AGENDA ITEM: Rules ready for W3C publication #1120

Closed

Jym77 previously requested changes Aug 18, 2020

View reviewed changes

Rearrange the expectation

21badb0

WilcoFiers requested a review from Jym77 August 19, 2020 08:14

WilcoFiers added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Aug 19, 2020

Jym77 approved these changes Aug 19, 2020

View reviewed changes

WilcoFiers added reviewers wanted and removed Review Call 1 week Call for review for small changes labels Aug 19, 2020

daniel-montalvo previously requested changes Aug 19, 2020

View reviewed changes

_rules/visible-label-in-accessible-name-2ee8b8.md Outdated Show resolved Hide resolved

Apply suggestions from code review

4bc287a

Co-authored-by: daniel-montalvo <49305434+daniel-montalvo@users.noreply.github.com>

WilcoFiers requested a review from daniel-montalvo August 19, 2020 10:15

daniel-montalvo approved these changes Aug 19, 2020

View reviewed changes

jeeyyy approved these changes Aug 19, 2020

View reviewed changes

Merge branch 'develop' into visible-text-subjective

f6490c8

WilcoFiers added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Aug 24, 2020

EmmaJP approved these changes Aug 27, 2020

View reviewed changes

Merge branch 'develop' into visible-text-subjective

708a1bc

WilcoFiers merged commit c363fe0 into develop Sep 7, 2020

WilcoFiers deleted the visible-text-subjective branch September 7, 2020 12:06

kasperisager mentioned this pull request Sep 23, 2020

Visible label is part of accessible name (2ee8b8): Expectation seems to have unintended consequences #1458

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make visible text content definition objective #1419

make visible text content definition objective #1419

WilcoFiers commented Aug 18, 2020 •

edited

Jym77 left a comment

Jym77 Aug 18, 2020

Jym77 Aug 18, 2020

WilcoFiers Aug 18, 2020

Jym77 left a comment

Jym77 Aug 18, 2020

WilcoFiers Aug 18, 2020

Jym77 Aug 18, 2020

WilcoFiers Aug 19, 2020

Jym77 left a comment

Jym77 commented Aug 19, 2020

EmmaJP left a comment •

edited

WilcoFiers commented Sep 7, 2020

	The _visible text content_ of an [element][] is a set of all [visible][] [text node][] that are a [descendant][] in the [flat tree][] of the element.
	The _visible text content_ of an [element][] is a set of all [visible][] [text nodes][text node] that are [descendants][descendant] in the [flat tree][] of this element.

	All [text nodes][] in the [visible text content][] of each target element matches, or is contained within the [accessible name][] of the target element, except for [text nodes][] contains [non-text content][]. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.
	Each [text node][] in the [visible text content][] of each target element matches, or is contained within, the [accessible name][] of this target element, except for [text nodes][] containing [non-text content][]. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.

	All [text nodes][] in the [visible text content][] of each target element matches, or is contained within the [accessible name][] of the target element, except for [text nodes][] contains [non-text content][]. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.
	Each [text node][] that is in the [visible text content][] of each target element and does not contain [non-text content][] matches, or is contained within, the [accessible name][] of the target element. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.

	All [text nodes][] in the [visible text content][] of each target element matches, or is contained within the [accessible name][] of the target element, except for characters used to express [non-text content][]. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.
	Each [text nodes][] in the [visible text content][] of each target element matches, or is contained within the [accessible name][] of this target element, except for characters used to express [non-text content][]. Leading and trailing [whitespace][] and difference in case sensitivity should be ignored.

make visible text content definition objective #1419

make visible text content definition objective #1419

Conversation

WilcoFiers commented Aug 18, 2020 • edited

Jym77 left a comment

Choose a reason for hiding this comment

Jym77 Aug 18, 2020

Choose a reason for hiding this comment

Jym77 Aug 18, 2020

Choose a reason for hiding this comment

WilcoFiers Aug 18, 2020

Choose a reason for hiding this comment

Jym77 left a comment

Choose a reason for hiding this comment

Jym77 Aug 18, 2020

Choose a reason for hiding this comment

WilcoFiers Aug 18, 2020

Choose a reason for hiding this comment

Jym77 Aug 18, 2020

Choose a reason for hiding this comment

WilcoFiers Aug 19, 2020

Choose a reason for hiding this comment

Jym77 left a comment

Choose a reason for hiding this comment

Jym77 commented Aug 19, 2020

EmmaJP left a comment • edited

Choose a reason for hiding this comment

WilcoFiers commented Sep 7, 2020

WilcoFiers commented Aug 18, 2020 •

edited

EmmaJP left a comment •

edited