Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update tomcat to v8.5.51 #410

Merged
merged 1 commit into from Mar 4, 2020
Merged

chore(deps): update tomcat to v8.5.51 #410

merged 1 commit into from Mar 4, 2020

Conversation

bjagg
Copy link
Member

@bjagg bjagg commented Mar 4, 2020 •
edited

Checklist
Description of change

@bjagg bjagg added the bug label Mar 4, 2020
@bjagg bjagg self-assigned this Mar 4, 2020
jgribonvald
jgribonvald approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@jgribonvald jgribonvald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to provide a fix to a CVE.

@ChristianMurphy: I'm wondering why renovate isn't working to update a such "dependency"

@bjagg bjagg merged commit 4f34a25 into uPortal-Project:master Mar 4, 2020
@ChristianMurphy
Copy link
Member

I'm wondering why renovate isn't working to update a such "dependency"

uPortal-start's renovate was unavailable due to renovatebot/renovate#4467, the awesome folks on the renovate team have resolved that, currently the bot is catching back up.
Now there appears to be a regression on renovatebot/renovate#3194 PRs are being opened and closed in a loop 😓

We may look into the renovate logs and at the dashboard to see if there are any remaining errors/bugs we can help resolve to get the updates coming through smoothly, as they are on other uPortal projects.

@ChristianMurphy
Copy link
Member

@jgribonvald the renovate config has been updated to setup a dashboard issue: #440
to give insights into what renovate has open and has queued for updates

@jgribonvald
Copy link
Contributor

Thanks @ChristianMurphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmtran jonathanmtran jonathanmtran approved these changes

@jgribonvald jgribonvald jgribonvald approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@apetro apetro Awaiting requested review from apetro

@jimhelwig jimhelwig Awaiting requested review from jimhelwig

@cousquer cousquer Awaiting requested review from cousquer

@cbeach47 cbeach47 Awaiting requested review from cbeach47

Assignees

@bjagg bjagg

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bjagg @ChristianMurphy @jgribonvald @jonathanmtran